[PATCH] D33894: Align definition of DW_OP_plus with DWARF spec [3/3]

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen created this revision.
Herald added a subscriber: aprantl.

This patch is part of 3 patches that together form a single patch, but must be introduced in stages in order not to break things.
 
The way that LLVM interprets DW_OP_plus in DIExpression nodes is basically that of the DW_OP_plus_uconst operator since LLVM expects an unsigned constant operand. This unnecessarily restricts the DW_OP_plus operator, preventing it from being used to describe the evaluation of runtime values on the expression stack. These patches try to align the semantics of DW_OP_plus and DW_OP_minus with that of the DWARF definition, which pops two elements off the expression stack, performs the operation and pushes the result back on the stack.
 
This is done in three stages:
	•	The first patch (LLVM) adds support for DW_OP_plus_uconst and changes all uses (and tests) of DW_OP_plus to use DW_OP_plus_uconst.
 
	•	The second patch (Clang) contains changes to use DW_OP_plus_uconst instead of DW_OP_plus.
 
	•	The third patch (LLVM) changes the semantics of DW_OP_plus to be in line with it’s DWARF meaning. It also does this for DW_OP_minus.


https://reviews.llvm.org/D33894

Files:
  docs/LangRef.rst
  include/llvm/IR/DebugInfoMetadata.h
  lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  lib/CodeGen/AsmPrinter/DwarfExpression.h
  lib/IR/DebugInfoMetadata.cpp
  test/DebugInfo/X86/dw_op_minus.ll
  test/DebugInfo/X86/dw_op_minus_direct.ll
  test/DebugInfo/X86/safestack-byval.ll
  test/Transforms/InstCombine/debuginfo-dce.ll
  test/Transforms/SafeStack/X86/debug-loc.ll
  test/Transforms/SafeStack/X86/debug-loc2.ll
  unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33894.101398.patch
Type: text/x-patch
Size: 12731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170605/6258b6f5/attachment.bin>