[PATCH] D33786: [ARM] Fix Neon vector type alignment to 64-bit

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: test/CodeGen/neon-aapcs-align.c:9
+// RUN: -target-feature +neon -emit-llvm -w -o - %s | FileCheck %s -check-prefix=CHECK -check-prefix=OTHERS
+
+#include <arm_neon.h>
----------------
srhines wrote:
> javed.absar wrote:
> > srhines wrote:
> > > Can you make sure that an Android triple doesn't trigger this? I worry because I am not sure what getABI() will return in that case.
> > Could you please elaborate.There is a test already  'armv7-none-linux-androideabi'.
> > 
> > lib/Basic/Targets.cpp:5357:: case llvm::Triple::Android:
> > sets it to aapcs-linux
> > 
> Yes, but you are also passing -target-abi here. I wanted confirmation that this will always be passed on the cc1 line. I think the line from Targets.cpp confirms that this is going to be the case (unless someone explicitly passes a different -target-abi option to cc1. Thanks.
This is odd. On Android alone, it should be 128. In anything + aapcs, it should be 64, including Android. Explicit behaviour trumps default behaviour. 

Do we have tests to make sure that the right CC1 flags are passed down?

We need two types of tests here: default behaviour and overriden behaviour.

I'd also add a GNUEABI and FreeBSD lines, because they're sufficiently different from the ones above.


https://reviews.llvm.org/D33786