[PATCH] D33716: Provide path to Solaris.h include (Bug 28370)

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 4 12:17:48 PDT 2017


Kamil Rytarowski via Phabricator <reviews at reviews.llvm.org> writes:

> My personal opinion is that `-include` is the wrong way of doing the work.

True, and I'd like to get rid of that file if possible.  Until then,
however, it should made work as intended, which is what the current
patch is about.

> At least part of this code (endian) perhaps should go to
> `include/llvm/Support/Host.h`.

Even better, one can get rid of the endianess stuff completely by
converting the few remaining uses of BYTE_ORDER etc. by __BYTE_ORDER__
which are predefined by both clang and gcc and are used already in many
places.  I mean to do that as a followup.

I'll check why the rest is needed and how to deal with if so.

	Rainer


More information about the llvm-commits mailing list