[PATCH] D33880: COFF: Introduce LD shim around LINK

[Martell Malone via Phabricator via llvm-commits]

martell added inline comments.


================
Comment at: lld/lib/Shim/COFFLdOptions.td:21
+
+// Currently stubs to avoid errors
+def Bdynamic: F<"Bdynamic">, HelpText<"Link against shared libraries">;
----------------
This is enough to get hello worlds working and cmake passing checks.


================
Comment at: lld/lib/Shim/COFFLdShim.cpp:1
+//===- lib/Driver/COFFLdShim.cpp ------------------------------------------===//
+//
----------------
Location Okay?


================
Comment at: lld/lib/Shim/COFFLdShim.cpp:144
+  }
+  // Let the Link Driver handle this error?
+  //if (Files.empty() && ErrorCount == 0)
----------------
Do I let LINK.exe handle such errors?


================
Comment at: lld/tools/lld/lld.cpp:123
   case Gnu:
-    return !elf::link(Args, true);
+    if (isPETarget(Args))
+      return !coff::ldshim(Args);
----------------
I'm not quite sure if I should do this here or in the ELF's `Driver.cpp` where it checks the emulation.
Suggestions welcome


Repository:
  rL LLVM

https://reviews.llvm.org/D33880