[PATCH] D33863: [DAGComine] (fadd x, undef) -> undef and (fmul x, undef) -> undef

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 4 10:08:44 PDT 2017


spatel added reviewers: efriedma, nlopes, regehr, sanjoy, majnemer.
spatel added a comment.

We don't have these folds in IR (InstSimplify).

1. Is that an oversight or are we intentionally avoiding FP undef folding?
2. If it's an oversight, do we still need to do this in the DAG? Or does having the folds in IR avoid the end problem in cases that you are looking at?
3. If this is valid, then why limit it to fmul+fadd? Are fsub and fdiv/frem different?


https://reviews.llvm.org/D33863





More information about the llvm-commits mailing list