[PATCH] D33753: [libcxxabi] Add back HandleLLVMOptions for out of tree builds

[Martell Malone via Phabricator via llvm-commits]

martell added a comment.

Just to be clear this causes a bunch of problems for my use case

  Run Build Command:"/usr/local/bin/ninja" "cmTC_a0bd6"
  [1/2] Building CXX object CMakeFiles/cmTC_a0bd6.dir/CMakeCXXCompilerABI.cpp.obj
  [2/2] Linking CXX executable cmTC_a0bd6.exe
  FAILED: cmTC_a0bd6.exe 
  : && /Users/martell/llvm/usr/bin/x86_64-w64-mingw32-clang++ -v CMakeFiles/cmTC_a0bd6.dir/CMakeCXXCompilerABI.cpp.obj -o cmTC_a0bd6.exe -Wl,--out-implib,libcmTC_a0bd6.dll.a -Wl,--major-image-version,0,--minor-image-version,0   && :
  clang version 5.0.0 (trunk 304663) (llvm/trunk 304665)
  Target: x86_64--windows-gnu
  Thread model: posix
  InstalledDir: /Users/martell/llvm/usr/bin
   "/Users/martell/llvm/usr/bin/lld" -flavor gnu -m i386pep -Bdynamic -o cmTC_a0bd6.exe /Users/martell/llvm/usr/x86_64-w64-mingw32/lib/crt2.o /Users/martell/llvm/usr/x86_64-w64-mingw32/lib/crtbegin.o -L/Users/martell/llvm/usr/x86_64-w64-mingw32/lib -L/Users/martell/llvm/usr/lib -L/Users/martell/llvm/usr/x86_64-w64-mingw32/sys-root/mingw/lib CMakeFiles/cmTC_a0bd6.dir/CMakeCXXCompilerABI.cpp.obj --out-implib libcmTC_a0bd6.dll.a --major-image-version 0 --minor-image-version 0 -lc++ -lmingw32 /Users/martell/llvm/usr/lib/clang/5.0.0/lib/windows/libclang_rt.builtins-x86_64.a -lmoldname -lmingwex -lmsvcrt -ladvapi32 -lshell32 -luser32 -lkernel32 /Users/martell/llvm/usr/x86_64-w64-mingw32/lib/crtend.o
  error: Unable to find library -lc++

I need to specifically define to even get this far.

  -DLLVM_NO_OLD_LIBSTDCXX=TRUE
  -DCXX_SUPPORTS_CXX11=TRUE

Not something I think I should have to do to bootstrap.
Can you tell me everything you specifically need from `HandleLLVMOptions` so I can extract that into libcxxabi's cmake modules


Repository:
  rL LLVM

https://reviews.llvm.org/D33753