[PATCH] D30562: Add Instruction number to LSR cost model (PR23384) part 3 of 3

Sat Jun 3 15:27:06 PDT 2017

Yeah, that’s strange.

> On Jun 3, 2017, at 12:27 PM, Sanjoy Das <sanjoy at playingwithpointers.com> wrote:
> 
> Hi,
> 
> On Tue, Mar 14, 2017 at 10:59 AM, Quentin Colombet via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> qcolombet requested changes to this revision.
>> qcolombet added a comment.
>> This revision now requires changes to proceed.
>> 
>> Hi,
>> 
>> I see two different things in that patch:
>> 
>> 1. X86 cost model change
>> 2. GenerateCrossUseICmpZero
>> 
>> Please make two separate patches.
>> 
>> For both cases, I expect a thorough benchmarking numbers for Os and https://reviews.llvm.org/owners/package/3/.
> 
> The "https://reviews.llvm.org/owners/package/3/" link seems spam -- is
> it possible that phabricator has been compromised?
> 
> -- Sanjoy