[PATCH] D33600: Adjust sanitizers for FreeBSD 64-bit inode update

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 3 04:50:20 PDT 2017


krytarowski added a comment.

In https://reviews.llvm.org/D33600#772087, @dim wrote:

> In https://reviews.llvm.org/D33600#772084, @krytarowski wrote:
>
> > Why does this code live in a Linux file? Are there plans to split it out, rename?
>
>
> I guess because at that time it was easiest to add it with `#ifdef`s?  At some point the ifdef maze will become too large, and then it will make sense to split it out, like the Mac and Windows versions.


There is also an option to rename it to something generic like "posix". For now I will add NetBSD ifdefs and we will evaluate afterwards.


Repository:
  rL LLVM

https://reviews.llvm.org/D33600





More information about the llvm-commits mailing list