[PATCH] D33680: [ELF] - Resolve references properly when using .symver directive

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 23:45:31 PDT 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

>    // It is an error if the specified version is not defined.
> -  error(toString(File) + ": symbol " + S + " has undefined version " + Verstr);
> +  if (Config->Shared)
> +    error(toString(File) + ": symbol " + S + " has undefined version " +
> +          Verstr);

Why do you needed to add "if (Config->Shared)"? The patch looks good
otherwise, but I would like to understand this part.

Cheers,
Rafael


More information about the llvm-commits mailing list