[PATCH] D33854: Introduce the new feature "abi-breaking-checks"

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 15:56:21 PDT 2017


chapuni created this revision.

A few tests in llvm/test/Transforms/Util/PredicateInfo/ are using -reverse-iterate.
The option -reverse-iterate is enabled with +Asserts in usual cases, but it can be turned on/off regardless of LLVM_ENABLE_ASSERTIONS.

I think it is better to introduce the new feature "abi-breaking-checks" for that.


Repository:
  rL LLVM

https://reviews.llvm.org/D33854

Files:
  llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll
  llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll
  llvm/trunk/test/lit.cfg
  llvm/trunk/test/lit.site.cfg.in


Index: llvm/trunk/test/lit.site.cfg.in
===================================================================
--- llvm/trunk/test/lit.site.cfg.in
+++ llvm/trunk/test/lit.site.cfg.in
@@ -24,6 +24,7 @@
 config.go_executable = "@GO_EXECUTABLE@"
 config.enable_shared = @ENABLE_SHARED@
 config.enable_assertions = @ENABLE_ASSERTIONS@
+config.enable_abi_breaking_checks = "@LLVM_ENABLE_ABI_BREAKING_CHECKS@"
 config.targets_to_build = "@TARGETS_TO_BUILD@"
 config.native_target = "@LLVM_NATIVE_ARCH@"
 config.llvm_bindings = "@LLVM_BINDINGS@".split(' ')
Index: llvm/trunk/test/lit.cfg
===================================================================
--- llvm/trunk/test/lit.cfg
+++ llvm/trunk/test/lit.cfg
@@ -546,3 +546,6 @@
 
 if config.have_libxar:
     config.available_features.add('xar')
+
+if config.enable_abi_breaking_checks == "1":
+    config.available_features.add('abi-breaking-checks')
Index: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll
===================================================================
--- llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll
+++ llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll
@@ -1,4 +1,4 @@
-; REQUIRES: asserts
+; REQUIRES: abi-breaking-checks
 ; NOTE: The flag -reverse-iterate is present only in a +Asserts build.
 ; Hence, this test has been split from testandor.ll to test with -reverse-iterate.
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
Index: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll
===================================================================
--- llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll
+++ llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll
@@ -1,4 +1,4 @@
-; REQUIRES: asserts
+; REQUIRES: abi-breaking-checks
 ; NOTE: The flag -reverse-iterate is present only in a +Asserts build.
 ; Hence, this test has been split from condprop.ll to test with -reverse-iterate.
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33854.101286.patch
Type: text/x-patch
Size: 2019 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170602/8b909241/attachment.bin>


More information about the llvm-commits mailing list