[PATCH] D33846: [IRCE] Canonicalize pre/post loops after the blocks are added into parent loop

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/comments addressed before submission.



================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:1391
+  auto CanonicalizeLoop = [&] (Loop *L, bool IsOriginalLoop) {
+    if (!L)
+      return;
----------------
minor: I'd hoist the null check to the caller so it's more explicit.


================
Comment at: test/Transforms/IRCE/correct-loop-info.ll:12
+define void @baz() personality i32* ()* @ham {
+bb:
+  br label %outerheader
----------------
Add checks just so we see what the output should look like.  Consider using the update script.


https://reviews.llvm.org/D33846