[PATCH] D33320: [SLP] Improve comments and naming of functions/variables/members, NFC.
Adam Nemet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 2 13:15:25 PDT 2017
anemet added inline comments.
================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4782-4783
+ // horizontal reduction.
+ // INTERRUPT THE PROCESS IF THE Root INSTRUCITON ITSELF WAS VECTORIZED OR ALL
+ // SUB-TREES NOT HIGHER THAN RecursionMaxDepth WERE ANALYZED/VECTORIZED.
+ SmallVector<std::pair<WeakVH, unsigned>, 8> Stack(1, {Root, 0});
----------------
ABataev wrote:
> anemet wrote:
> > Something got messed up with upper/lowercase here.
> I tried to keep the original names of the variables. Should I capitalize them too?
Oh sorry, no I only meant the capitalize the first letter of the sentence.
Looking at it again, I think I misread this and thought that "subtrees" was the beginning of a sentence. It's not so just go back to the original version. Sorry about the confusion!
https://reviews.llvm.org/D33320
More information about the llvm-commits
mailing list