[PATCH] D33843: Create a new library called ObjectLayout, and move headers from Support to there.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 11:46:25 PDT 2017


zturner added a comment.

In https://reviews.llvm.org/D33843#771680, @chandlerc wrote:

> About the only thing I find questionable here is the Magic.h bit... And really only because it also has file magic for archives and bitcode. But that's probably OK.
>
> However, I hate to say this, but `ObjectLayout` doesn't seem like the right name. `ObjectFormat` would be closer or `ObjectFile` or something.


One idea would be to call this library `BinaryFormat`.  That encompasses things that aren't necessarily object files.


https://reviews.llvm.org/D33843





More information about the llvm-commits mailing list