[PATCH] D32779: DWARF: Implementation of v5 string offsets table (.debug_str_offsets[.dwo] section)/consumer

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp marked 5 inline comments as done.
wolfgangp added inline comments.


================
Comment at: test/DebugInfo/dwarfdump-str-offsets.test:57-67
+CHECK-NEXT: 0x00000000: Contribution size = 12, Version = 5
+CHECK-NEXT: 0x00000008: 00000000
+CHECK-NEXT: 0x0000000c: 00000018
+CHECK-NEXT: 0x00000010: 00000027
+CHECK-NEXT: 0x00000014: Contribution size = 12, Version = 5
+CHECK-NEXT: 0x0000001c: 00000000
+CHECK-NEXT: 0x00000020: 00000036
----------------
dblaikie wrote:
> Reckon it'd be worth printing the strings that these offsets refer to here? (since the strings are indirected and printed in the debug_info (which has to go through this table and then on to the strings table) it seems weird to have them missing here, maybe?
I agree. I wasn't sure if somebody who is exclusively looking at the string offsets table would really be interested but there is no reason not to have the strings there as well.


https://reviews.llvm.org/D32779