[PATCH] D33840: [DAGCombine] Do not try to deduplicate commutative operations if both operand are the same.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 10:17:50 PDT 2017


RKSimon added a comment.

Do you have any stats?



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1565
   // If N is a commutative binary node, try commuting it to enable more
   // sdisel CSE.
   if (!RV.getNode() && SelectionDAG::isCommutativeBinOp(N->getOpcode()) &&
----------------
Why you're here, please can you change this to SDISel to make it clearer.


https://reviews.llvm.org/D33840





More information about the llvm-commits mailing list