[PATCH] D33492: [ARM] Support fixup for Thumb2 modified immediate

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 05:36:25 PDT 2017


peter.smith updated this revision to Diff 101193.
peter.smith added a comment.
Herald added a subscriber: kristof.beyls.

Updated diff to correct immediate mask to 0xff which maps to imm8 in the ARM ARM, previously I had used 0xfff which caused the destination register to get corrupted when the high bits of the immediate were set.

Tests now have correct register numbers. Apologies for my previous blindness, I concentrated on the numbers and missed that the registers had been corrupted.


https://reviews.llvm.org/D33492

Files:
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
  lib/Target/ARM/MCTargetDesc/ARMFixupKinds.h
  lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp
  test/MC/ARM/big-endian-thumb2-fixup.s
  test/MC/ARM/t2-modified-immediate-fixup-error1.s
  test/MC/ARM/t2-modified-immediate-fixup-error2.s
  test/MC/ARM/t2-modified-immediate-fixup.s
  test/MC/ARM/thumb2-diagnostics.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33492.101193.patch
Type: text/x-patch
Size: 9184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170602/321c17f6/attachment.bin>


More information about the llvm-commits mailing list