[PATCH] D33464: [PM][WIP] Enable out-of-tree registration of passes with the new PassBuilder

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe updated this revision to Diff 101178.
philip.pfaffe marked 10 inline comments as done.
philip.pfaffe added a comment.

Address Review comments

This contains one functional change: I've moved the parseXPassPipeline() functions into the public API, and added the PB instance to the TopLevel parsing callback. The reason is that when I'm being invoked for the TopLevel pipeline, I usually don't actually want to handle all the parsing myself. Instead, I'd only like to set up the PM stack (either by messing with the PipelineElement nest, as PB does, or prepare the stack of PM objects), and then hand this back into the PassBuilder.

Also:

- Inline CallbackT using-decls as well as the function definitions into the callback registration functions in the header.
- Commentary


https://reviews.llvm.org/D33464

Files:
  include/llvm/Passes/PassBuilder.h
  lib/Passes/PassBuilder.cpp
  test/Other/new-pm-lto-defaults.ll
  tools/opt/NewPMDriver.cpp
  unittests/IR/CMakeLists.txt
  unittests/IR/HookManagerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33464.101178.patch
Type: text/x-patch
Size: 34448 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170602/569c7372/attachment.bin>