[polly] r304529 - [NFC] [CodeGen] Bail out of per-scop performance reporting if not supported.

Siddharth Bhat via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 2 01:44:19 PDT 2017


Author: bollu
Date: Fri Jun  2 03:44:19 2017
New Revision: 304529

URL: http://llvm.org/viewvc/llvm-project?rev=304529&view=rev
Log:
[NFC] [CodeGen] Bail out of per-scop performance reporting if not supported.

We should bail out if performance monitoring is not supported, since
we would have no information to print per-scop, and `FinalStartBB`,
`ReturnFromFinal` would be `nullptr`.

Assert that these are not `nullptr` if performance monitoring is supported.

Modified:
    polly/trunk/lib/CodeGen/PerfMonitor.cpp

Modified: polly/trunk/lib/CodeGen/PerfMonitor.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/PerfMonitor.cpp?rev=304529&r1=304528&r2=304529&view=diff
==============================================================================
--- polly/trunk/lib/CodeGen/PerfMonitor.cpp (original)
+++ polly/trunk/lib/CodeGen/PerfMonitor.cpp Fri Jun  2 03:44:19 2017
@@ -157,6 +157,14 @@ Function *PerfMonitor::insertFinalReport
 }
 
 void PerfMonitor::AppendScopReporting() {
+  if (!Supported)
+    return;
+
+  assert(FinalStartBB && "Expected FinalStartBB to be initialized by "
+                         "PerfMonitor::insertFinalReporting.");
+  assert(ReturnFromFinal && "Expected ReturnFromFinal to be initialized by "
+                            "PerfMonitor::insertFinalReporting.");
+
   Builder.SetInsertPoint(FinalStartBB);
   ReturnFromFinal->eraseFromParent();
 




More information about the llvm-commits mailing list