[PATCH] D33819: Add placeholder for more extensive verification of psuedo ops

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 19:33:27 PDT 2017


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

Not much to say at this point except: More machine verifiers are a good thing here esp. since those patchpoint related instructions are variadic/generic enough that our usual MCInstrDesc mechanism don't do much anymore.



================
Comment at: lib/CodeGen/MachineVerifier.cpp:926-928
+  switch(MCID.getOpcode()) {
+  default:
+    break;
----------------
You can probably move the TargetOpcode::G_LOAD/TargetOpcode::G_STORE cases from above into the switch as well?


https://reviews.llvm.org/D33819





More information about the llvm-commits mailing list