[lld] r304484 - [CodeView] Properly align symbol records on read/write.

[Galina Kistanova via llvm-commits]

Thank you. Sorry for the noise.

Thanks

Galina

On Thu, Jun 1, 2017 at 4:49 PM, Zachary Turner <zturner at google.com> wrote:

> Should already be fixed, the latest build is green.
>
> On Thu, Jun 1, 2017 at 4:47 PM Galina Kistanova <gkistanova at gmail.com>
> wrote:
>
>> Hello Zachary,
>>
>> This commit broke one of our builders:
>>
>> http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/8784
>>
>> Please have a look?
>>
>> Thanks
>>
>>
>> Galina
>>
>>
>> On Thu, Jun 1, 2017 at 2:52 PM, Zachary Turner via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: zturner
>>> Date: Thu Jun  1 16:52:41 2017
>>> New Revision: 304484
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=304484&view=rev
>>> Log:
>>> [CodeView] Properly align symbol records on read/write.
>>>
>>> Object files have symbol records not aligned to any particular
>>> boundary (e.g. 1-byte aligned), while PDB files have symbol
>>> records padded to 4-byte aligned boundaries.  Since they share
>>> the same reading / writing code, we have to provide an option to
>>> specify the alignment and propagate it up to the producer or
>>> consumer who knows what the alignment is supposed to be for the
>>> given container type.
>>>
>>> Added a test for this by modifying the existing PDB -> YAML -> PDB
>>> round-tripping code to round trip symbol records as well as types.
>>>
>>> Differential Revision: https://reviews.llvm.org/D33785
>>>
>>> Modified:
>>>     lld/trunk/COFF/PDB.cpp
>>>
>>> Modified: lld/trunk/COFF/PDB.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/PDB.
>>> cpp?rev=304484&r1=304483&r2=304484&view=diff
>>> ============================================================
>>> ==================
>>> --- lld/trunk/COFF/PDB.cpp (original)
>>> +++ lld/trunk/COFF/PDB.cpp Thu Jun  1 16:52:41 2017
>>> @@ -157,7 +157,8 @@ static void dumpDebugS(ScopedPrinter &W,
>>>      fatal(EC, "StreamReader.readArray<CVSymbolArray> failed");
>>>
>>>    TypeDatabase TDB(0);
>>> -  CVSymbolDumper SymbolDumper(W, TDB, nullptr, false);
>>> +  CVSymbolDumper SymbolDumper(W, TDB, CodeViewContainer::ObjectFile,
>>> nullptr,
>>> +                              false);
>>>    if (auto EC = SymbolDumper.dump(Symbols))
>>>      fatal(EC, "CVSymbolDumper::dump failed");
>>>  }
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170601/33af0493/attachment.html>