[PATCH] D33807: [CodeView] Allow Debug Subsections to be read/written in any order

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/DbiModuleDescriptorBuilder.cpp:42
+  uint32_t Size = sizeof(uint32_t);   // Signature
+  Size += alignTo(SymbolByteSize, 4); // Symbol Data
+  Size += 0;                          // TODO: Layout.C11Bytes
----------------
inglorion wrote:
> Do we need this? I thought we made it so that SymbolByteSize is always a multiple of 4 when writing PDBs. Also, is this related to the other changes here or a holdover from your earlier alignment fixes?
I originally started investigating the alignment issue on the same branch as I was doing this patch.  Then when I committed the other one and rebased on top of trunk, these changes were still here.  I need to find all these remnants and remove them.


https://reviews.llvm.org/D33807