[PATCH] D33795: [PredicateInfo] Enable -reverse-iterate tests only for +Asserts builds

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added a comment.

In https://reviews.llvm.org/D33795#770869, @chapuni wrote:

> Would there be any cases with ABI_BREAKING_CHECKS enabled but ENABLE_ASSERTIONS=OFF?
>
> I could introduce a new feature "REQUIRES: abi-breaking-checks"


@chapuni Currently, I see that ABI_BREAKING_CHECKS is turned OFF only if it is explicitly set to FORCE_OFF. Otherwise, it is enabled if ASSERTS are enabled (in cmake/modules/HandleLLVMOptions.cmake).
I am not sure if there is some buildbot which explicitly turns ABI_BREAKING off.
Introducing REQUIRES: abi-breaking-checks is a good idea though.


Repository:
  rL LLVM

https://reviews.llvm.org/D33795