[PATCH] D33800: [SelectionDAG] Update the dominator after splitting critical edges

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:405
   ORE = make_unique<OptimizationRemarkEmitter>(&Fn);
+  DominatorTree *DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree();
 
----------------
Can you use getAnalysisIfAvailable here?


================
Comment at: test/CodeGen/X86/O0-pipeline.ll:35
 ; CHECK-NEXT:       Module Verifier
+; CHECK-NEXT:       Dominator Tree Construction
 ; CHECK-NEXT:       X86 DAG->DAG Instruction Selection
----------------
This test is specifically here to make sure we don't add unnecessary passes to `-O0`.  This is not progress in the right direction.


https://reviews.llvm.org/D33800