[PATCH] D33785: [CodeView] Fix alignment / padding when writing symbol records

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 14:31:31 PDT 2017


amccarth added a comment.

In https://reviews.llvm.org/D33785#770614, @rnk wrote:

> I guess I'm saying it seems nice to always write aligned records until we come up with some reason to not write aligned records. Having the flexibility to do either seems good. We definitely have to read the unaligned records.


That's an interesting topic for another patch.  As Zach says, this doesn't affect writing the objects.

And even if it did, I'd be mildly concerned about aligning output more strictly than the tools we're trying to be compatible with.  If all our linker tests (for example) were based on neatly aligned object files, it would be easy for a bug to slip into the linker that assumes objects will always be neatly aligned.


https://reviews.llvm.org/D33785





More information about the llvm-commits mailing list