[PATCH] D33795: [PredicateInfo] Remove -reverse-iterate from tests as it breaks on Release builds

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 13:50:30 PDT 2017


(we definitely have tests that require assertions be enabled. Look at the
tests for the debug counting infrastructure)

On Thu, Jun 1, 2017 at 1:49 PM, Daniel Berlin <dberlin at dberlin.org> wrote:

> You can split the tests and use Require:Asserts i believe
>
> On Thu, Jun 1, 2017 at 12:07 PM, Mandeep Singh Grang via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> mgrang created this revision.
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D33795
>>
>> Files:
>>   test/Transforms/Util/PredicateInfo/condprop.ll
>>   test/Transforms/Util/PredicateInfo/testandor.ll
>>
>>
>> Index: test/Transforms/Util/PredicateInfo/testandor.ll
>> ===================================================================
>> --- test/Transforms/Util/PredicateInfo/testandor.ll
>> +++ test/Transforms/Util/PredicateInfo/testandor.ll
>> @@ -1,6 +1,5 @@
>>  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
>>  ; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s
>> -; RUN: opt -print-predicateinfo -reverse-iterate < %s 2>&1 | FileCheck %s
>>
>>  declare void @foo(i1)
>>  declare void @bar(i32)
>> Index: test/Transforms/Util/PredicateInfo/condprop.ll
>> ===================================================================
>> --- test/Transforms/Util/PredicateInfo/condprop.ll
>> +++ test/Transforms/Util/PredicateInfo/condprop.ll
>> @@ -1,6 +1,5 @@
>>  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
>>  ; RUN: opt -print-predicateinfo -analyze  < %s 2>&1 | FileCheck %s
>> -; RUN: opt -print-predicateinfo -analyze -reverse-iterate  < %s 2>&1 |
>> FileCheck %s
>>
>>  @a = external global i32               ; <i32*> [#uses=7]
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170601/4c5fae81/attachment.html>


More information about the llvm-commits mailing list