[PATCH] D33702: Skip CFI and WholeProgramDevirt for dead functions.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/Transforms/IPO/WholeProgramDevirt.cpp:1327
         auto *FS = dyn_cast<FunctionSummary>(S.get());
-        if (!FS)
+        if (!FS || !FS->isLive())
           continue;
----------------
Is there test coverage for the not-live case here?


================
Comment at: test/Transforms/LowerTypeTests/Inputs/use-typeid1-dead.yaml:5
+    - Live: 0
+      TypeTests: [14276520915468743435] # guid("typeid1"), guid("typeid2")
+...
----------------
Just guid("typeid1") I think?


Repository:
  rL LLVM

https://reviews.llvm.org/D33702