[PATCH] D33734: [AArch64] Add fallback in FastISel fp16 conversions

I-Jui Sung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 13:06:12 PDT 2017


ijsung added inline comments.


================
Comment at: test/CodeGen/AArch64/arm64-fast-isel-conversion-fallback.ll:1
+; RUN: llc -O0 -verify-machineinstrs -mtriple=arm64-eabi -mcpu=cortex-a57 < %s | FileCheck --enable-var-scope %s
+
----------------
SjoerdMeijer wrote:
> kristof.beyls wrote:
> > I guess that -mcpu=cortex-a57 isn't needed in this test line?
> > For the actual tests, I think @SjoerdMeijer probably will be able to review them better than I can.
> The tests look very reasonable to me.
Revised the RUN line and removed the -mcpu. Thanks.


https://reviews.llvm.org/D33734





More information about the llvm-commits mailing list