[PATCH] D33743: (NFC) Track global summary liveness in GVFlags.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:458
+      if (S->isLive()) {
+        makeLiveRoot(ValueInfo(&Entry));
+        break;
----------------
eugenis wrote:
> pcc wrote:
> > I was thinking just push `ValueInfo(&Entry)` onto the worklist here. Then you can replace the other call to `makeLiveRoot` with the loop that sets summaries to live and remove `makeLiveRoot` entirely.
> But then we also need to do ++LiveSymbols in both places. I'm not sure it's a net win.
We just need to do it here, no? Otherwise we'd end up double counting live roots.


Repository:
  rL LLVM

https://reviews.llvm.org/D33743