[llvm] r304457 - Prefer static namespace-scoped variables over anon namespacing per style guide

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 12:20:27 PDT 2017


Author: dblaikie
Date: Thu Jun  1 14:20:26 2017
New Revision: 304457

URL: http://llvm.org/viewvc/llvm-project?rev=304457&view=rev
Log:
Prefer static namespace-scoped variables over anon namespacing per style guide

Also for consistency with the immediately preceeding variable
definition.

Modified:
    llvm/trunk/tools/bugpoint/OptimizerDriver.cpp

Modified: llvm/trunk/tools/bugpoint/OptimizerDriver.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/bugpoint/OptimizerDriver.cpp?rev=304457&r1=304456&r2=304457&view=diff
==============================================================================
--- llvm/trunk/tools/bugpoint/OptimizerDriver.cpp (original)
+++ llvm/trunk/tools/bugpoint/OptimizerDriver.cpp Thu Jun  1 14:20:26 2017
@@ -47,14 +47,13 @@ static cl::opt<bool> PreserveBitcodeUseL
     cl::desc("Preserve use-list order when writing LLVM bitcode."),
     cl::init(true), cl::Hidden);
 
-namespace {
 // ChildOutput - This option captures the name of the child output file that
 // is set up by the parent bugpoint process
-cl::opt<std::string> ChildOutput("child-output", cl::ReallyHidden);
-cl::opt<std::string> OptCmd("opt-command", cl::init(""),
-                            cl::desc("Path to opt. (default: search path "
-                                     "for 'opt'.)"));
-}
+static cl::opt<std::string> ChildOutput("child-output", cl::ReallyHidden);
+static cl::opt<std::string>
+    OptCmd("opt-command", cl::init(""),
+           cl::desc("Path to opt. (default: search path "
+                    "for 'opt'.)"));
 
 /// writeProgramToFile - This writes the current "Program" to the named bitcode
 /// file.  If an error occurs, true is returned.




More information about the llvm-commits mailing list