[PATCH] D33673: [Object/RelocVisitor] - Add support for R_X86_64_DTPOFF32 relocation.

[Rafael Avila de Espindola via llvm-commits]

George Rimar <grimar at accesssoftek.com> writes:
> Because DWARFContextInMemory currently prints a error, but continues parsing object in the case
> when something wrong with proccessing of relocations:
>
>       object::RelocVisitor V(Obj, L ? L->getTlsSize() : 0);
>       uint64_t Val = V.visit(Reloc.getType(), Reloc, SymInfoOrErr->Address);
>       if (V.error()) {
>         SmallString<32> Name;
>         Reloc.getTypeName(Name);
>         errs() << "error: failed to compute relocation: " << Name << "\n";
>         continue;
>       }
>
> So do you mean we should just teach RelocVisitor to resolve it just to something, like zero or symbol value,
> just to stop emiting error ?

No. We should propagate the error and fail the link.

BTW, these sections are also written out by lld, no? It seems odd to
relocate them twice. I wonder if we can do better.

Cheers,
Rafael