[PATCH] D33203: Add scheduler classes to integer/float horizontal operations

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 09:51:50 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86Schedule.td:82
+defm WriteHAdd  : X86SchedWritePair;
+defm WriteHAddY : X86SchedWritePair;
+defm WritePHAdd : X86SchedWritePair;
----------------
avt77 wrote:
> RKSimon wrote:
> > I'm not sure we should be introducing size specific versions - we don't do this for any other cases. Merge back into WriteHAdd?
> I did it specially because Jaguar has different numbers for Ymm and Xmm and we can't model such difference without the special SchedWrite. Is it OK?
Please can you use the instregex approach like you did in D33099? 


================
Comment at: lib/Target/X86/X86ScheduleSLM.td:144
+// TODO: at the moment we don't model horizontal ooperations here that's why
+// it's a simple place holder for future implementation
+
----------------
avt77 wrote:
> RKSimon wrote:
> > Isn't this comment out of date? You're modelling the horizontal operations below.
> In fact we did not model SLM here. I simply kept the current numbers: they could be wrong.
That's fine, thanks.


https://reviews.llvm.org/D33203





More information about the llvm-commits mailing list