[PATCH] D33746: [PGO] Dump branch condition type, branch probability and branch hotness as optimization remarks

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:222
+  ConstantInt *CV = dyn_cast<ConstantInt>(RHS);
+  if (CV) {
+    if (CV->isZero())
----------------
danielcdh wrote:
> Why not directly output the const int as a number?
The dump is used to collect data for static prediction tuning.  Only special values like 0,1,-1 are of interest to the predictor. All other constants only need to be aggregated.


https://reviews.llvm.org/D33746