[PATCH] D31194: [InstSimplify] Try to Constant Fold the Instruction before simplification

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 1 08:56:39 PDT 2017


dberlin added inline comments.


================
Comment at: test/Transforms/NewGVN/completeness.ll:403
 ; CHECK:       k:
-; CHECK-NEXT:    br i1 false, label [[C]], label [[O:%.*]]
+; CHECK-NEXT:    br i1 %{{.*}}, label [[C]], label [[O:%.*]]
 ; CHECK:       o:
----------------
Did you change this manually?
We normally use update_test_checks on these tests, and i've never seen it do that.
(also, the update would mean we lost optimization, since it should stay false)


https://reviews.llvm.org/D31194





More information about the llvm-commits mailing list