[PATCH] D33736: Add AMDGPU backend documentation.

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: docs/AMDGPUUsage.rst:414
+  The value ``EM_AMDGPU`` is used for the machine for all members of the AMD GPU
+  architecture family. The specific member is specified in the ``NT_HSA_ISA``
+  entry in the ``.note`` section (see :ref:`amdgpu-note-records`).
----------------
`NT_HSA_ISA` is never defined. Did you mean `NT_AMD_AMDGPU_ISA`?


================
Comment at: docs/AMDGPUUsage.rst:596
+
+For boolean values, 0 is used for false and 1 for true.
+
----------------
We use `false` and `true` respectively. See https://github.com/llvm-mirror/llvm/blob/master/test/CodeGen/AMDGPU/code-object-metadata-from-llvm-ir-full.ll#L561 as an example.


================
Comment at: docs/AMDGPUUsage.rst:991
+     :name: amdgpu-amdhsa-code-object-kernel-debug-properties-metadata-mapping-table
+
+     =================================== ============== ========= ==============
----------------
Add a todo saying to remove debug properties?


https://reviews.llvm.org/D33736