[PATCH] D33374: Do not legalize large setcc with setcce, introduce setcccarry and do it with usubo/setcccarry.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 1 03:54:38 PDT 2017
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - thanks.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34510
- if (Carry.getOpcode() == ISD::SETCC ||
- Carry.getOpcode() == X86ISD::SETCC ||
+ if (Carry.getOpcode() == X86ISD::SETCC ||
Carry.getOpcode() == X86ISD::SETCC_CARRY) {
----------------
deadalnix wrote:
> RKSimon wrote:
> > I'm curious why you're dropping ISD::SETCC support here - is the change independent of the rest of the patch?
> It never worked and is invalid. It could indeed be part of another diff.
OK, please commit this as a separate pre-commit, it doesn't need review.
https://reviews.llvm.org/D33374
More information about the llvm-commits
mailing list