[PATCH] D33696: TargetMachine: Indicate whether machine verifier passes.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 16:25:54 PDT 2017


MatzeB added inline comments.


================
Comment at: lib/Target/AVR/AVRTargetMachine.h:46
+    return false;
+  }
+
----------------
dylanmckay wrote:
> RKSimon wrote:
> > FYI I'm not sure we have any EXPENSIVE_CHECKS buildbot that enables AVR (or WebAssembly).
> Can confirm in the AVR case.
No I don't think we have. I also added this `return false;` defensively feel free to remove it if AVR is clean.

BTW: You can always manually run all lit tests with verify-machineinstrs with `llvm-lit -Dllc="llc -verify-machineinstrs"` that saves you the time to recompile with EXPENSIVE_CHECKS enabled.


Repository:
  rL LLVM

https://reviews.llvm.org/D33696





More information about the llvm-commits mailing list