[PATCH] D33635: [libcxxabi] rework CMakeLists.txt into modules

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 19:25:12 PDT 2017


martell added a comment.

> ! In https://reviews.llvm.org/D33635#769584, @EricWF wrote:
> Libc++ also has some other configuration changes to make that work, like handling LLVM_USE_SANITIZER, which libc++abi doesn't right now but did before...

Ahh I see, In that case we could add `include(HandleLLVMOptions OPTIONAL)` below `include(AddLLVM OPTIONAL)` in `HandleOutOfTreeLLVM.cmake`
I can either then re-evaluate why I have issues in cross compiling and either migrate the `LLVM_USE_SANITIZER` code to libcxxabi later or fix in another way.


Repository:
  rL LLVM

https://reviews.llvm.org/D33635





More information about the llvm-commits mailing list