[PATCH] D33635: [libcxxabi] rework CMakeLists.txt into modules

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 19:11:37 PDT 2017


martell added a comment.

In https://reviews.llvm.org/D33635#769577, @EricWF wrote:

> Urg... so all of the configuration done in that file is no longer handled?!? That's the opposite of a change that has no effect on functionality...


Correct. I would note however that libc++ does not depend on that module either.
I believe keeping libc++abi consistent with libc++ makes sense here.
Unless someone wants to reintroduce that dependency into libc++?


Repository:
  rL LLVM

https://reviews.llvm.org/D33635





More information about the llvm-commits mailing list