[PATCH] D33751: Add opt-bisect support for region passes

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

This looks straightforward. LGTM.



================
Comment at: lib/Analysis/RegionPass.cpp:286
+bool RegionPass::skipRegion(Region &R) const {
+  Function *F = R.getEntry()->getParent();
+  if (!F->getContext().getOptBisect().shouldRunPass(this, R))
----------------
I'd use a reference as it cannot be nullptr.


================
Comment at: lib/IR/OptBisect.cpp:64-65
+static std::string getDescription(const Region &R) {
+  // FIXME: Can we do better here?
+  return "region";
+}
----------------
Printing the names of the entry and exit blocks of a region?


Repository:
  rL LLVM

https://reviews.llvm.org/D33751