[PATCH] D33743: (NFC) Track global summary liveness in GVFlags.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 17:51:51 PDT 2017


pcc added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:458
+      if (S->isLive()) {
+        makeLiveRoot(ValueInfo(&Entry));
+        break;
----------------
I was thinking just push `ValueInfo(&Entry)` onto the worklist here. Then you can replace the other call to `makeLiveRoot` with the loop that sets summaries to live and remove `makeLiveRoot` entirely.


Repository:
  rL LLVM

https://reviews.llvm.org/D33743





More information about the llvm-commits mailing list