[PATCH] D33601: libunwind: fix building on mingw-w64

[Eric Fiselier via Phabricator via llvm-commits]

EricWF added inline comments.


================
Comment at: src/assembly.h:30
+#elif defined(_WIN32)
+#define HIDDEN_DIRECTIVE .globl
 #else
----------------
This seems like it's obviously not correct. What is going on with this?


================
Comment at: src/config.h:41
+#elif defined(_WIN32)
+  // #define _LIBUNWIND_BUILD_SJLJ_APIS
+  // #define _LIBUNWIND_SUPPORT_FRAME_APIS
----------------
Why are these commented out?


================
Comment at: src/config.h:55
+#ifdef _WIN32
+#define _LIBUNWIND_EXPORT
+#define _LIBUNWIND_HIDDEN
----------------
Shouldn't this be change to be a DLL import/export?


Repository:
  rL LLVM

https://reviews.llvm.org/D33601