[PATCH] D33349: [dfsan] Add explicit zero extensions for shadow parameters in function wrappers.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1529
+        CustomCI->setAttributes(CustomFn ? CustomFn->getAttributes()
+                                         : CI->getAttributes());
 
----------------
I'm a little uncomfortable with this because it seems like we're effectively dropping attributes from the call instruction. If we don't expect to create a function definition the attributes on the declaration shouldn't matter, so maybe we should be adding the zeroext attributes just to the call rather than to the declaration. 


https://reviews.llvm.org/D33349