[PATCH] D32911: [ScheduleDAG] Deal with already scheduled loads in ScheduleDAG.
Justin Bogner via llvm-commits
llvm-commits at lists.llvm.org
Wed May 31 11:33:55 PDT 2017
Nirav Dave via Phabricator <reviews at reviews.llvm.org> writes:
> niravd added a comment.
>
> Pinging again and adding comment to ease reviewer task.
>
> ================
> Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:967
> + // this would negate the benefit to unfolding so just return SU.
> + if (LoadSU->isScheduled)
> + return SU;
> ----------------
> For ease of review: these two line are the functional
> change. Everything else is just for cleanliness of code structure.
The rest of the code is just moved more or less verbatim into a
function, right? Seems straightforward enough. This LGTM.
More information about the llvm-commits
mailing list