[PATCH] D33696: TargetMachine: Indicate whether machine verifier passes.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: include/llvm/Target/TargetMachine.h:305
+  /// checks. This may be temporarily set to false to avoid test failures while
+  /// fixing a target.
+  virtual bool isMachineVerifierClean() const { return true; }
----------------
Would it be too strict to add a comment saying that targets should not become 'unclean' again once they are passing expensive checks?


================
Comment at: lib/Target/AVR/AVRTargetMachine.h:46
+    return false;
+  }
+
----------------
FYI I'm not sure we have any EXPENSIVE_CHECKS buildbot that enables AVR (or WebAssembly).


================
Comment at: lib/Target/Hexagon/HexagonTargetMachine.h:49
+  bool isMachineVerifierClean() const override {
+    return false;
+  }
----------------
Hexagon was clean on my last set of tests (PR32146 / PR33048)


Repository:
  rL LLVM

https://reviews.llvm.org/D33696