[PATCH] D33704: [DIBuilder] Add a more fine-grained finalization method

[Keno Fischer via Phabricator via llvm-commits]

loladiro added a comment.

> Will you only invoke it on functions to be cloned in clang or on all subprograms?

https://reviews.llvm.org/D33705 is the clang part of this. @dblaikie had some concerns (on the mailing list) - I had it only call it on cloned subprogram, but @dblaikie thought it might be more natural to call it immediately when irgen is done.

As for the name, I don't think finalizeVariables is necessarily a great name, because the semantics I want is that there's no temporary nodes left in that SP. Right now that might only be variables, but in the feature if there are ever others, I'd want this function to finalize those as well. I'm fine either way though.


https://reviews.llvm.org/D33704