[PATCH] D33704: [DIBuilder] Add a more fine-grained finalization method

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 09:01:49 PDT 2017


aprantl added a comment.

I was a bit scared by the description at first, but this is safe. Will you only invoke it on functions to be cloned in clang or on all subprograms?



================
Comment at: include/llvm/IR/DIBuilder.h:91
+    /// subprogram afterwards.
+    void finalizeSP(DISubprogram *SP);
+
----------------
I wonder if `finalizeVariable(DISubprogram *SP)` would be a more accurate name?


https://reviews.llvm.org/D33704





More information about the llvm-commits mailing list