[PATCH] D33594: [mips][dsp] Modify repl.ph to accept signed immediate values
Simon Dardis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 31 08:22:15 PDT 2017
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM with inline nit addressed.
================
Comment at: test/MC/Disassembler/Mips/micromips-dsp/valid.txt:97
0x00 0x20 0x86 0x7c # CHECK: rddsp $1, 2
-0x02 0x00 0x08 0x3d # CHECK: repl.ph $1, 512
+0x00 0x00 0x08 0x3d # CHECK: repl.ph $1, 0
0x00 0x30 0x05 0xfc # CHECK: repl.qb $1, 128
----------------
Nit: Where possible, avoid the use of 0 as a constant in these sort of tests. If the memory used by the compiler is zero-initialized, the test may be unstably passing.
================
Comment at: test/MC/Mips/micromips-dsp/valid.s:98
rddsp $1, 2 # CHECK: rddsp $1, 2 # encoding: [0x00,0x20,0x86,0x7c]
- repl.ph $1, 512 # CHECK: repl.ph $1, 512 # encoding: [0x02,0x00,0x08,0x3d]
+ repl.ph $1, 0 # CHECK: repl.ph $1, 0 # encoding: [0x00,0x00,0x08,0x3d]
repl.qb $1, 128 # CHECK: repl.qb $1, 128 # encoding: [0x00,0x30,0x05,0xfc]
----------------
Here too.
https://reviews.llvm.org/D33594
More information about the llvm-commits
mailing list