[PATCH] D33369: [PowerPC] Eliminate compares - add i64 sext/zext handling for equality

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 01:03:33 PDT 2017


nemanjai marked 3 inline comments as done.
nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2833
+                                             int64_t RHSValue, SDLoc dl) {
+  bool IsRHSZero = RHSValue == 0;
+  switch (CC) {
----------------
echristo wrote:
> Seems to be unused at the moment?
It's actually used in deciding whether we use the `LHS` or `(xor LSH, RHS)` as the operand to count leading zeros.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2855
+                                             int64_t RHSValue, SDLoc dl) {
+  bool IsRHSZero = RHSValue == 0;
+  switch (CC) {
----------------
echristo wrote:
> Ditto.
Same as above, but as input to add-immediate-with-carry instead of count leading zeros.


Repository:
  rL LLVM

https://reviews.llvm.org/D33369





More information about the llvm-commits mailing list