[PATCH] D33711: [TableGen] Clang changes to support Record::getValueAsString and getValueAsListOfStrings returning StringRef instead of std::string

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 23:50:50 PDT 2017


craig.topper added inline comments.


================
Comment at: utils/TableGen/ClangOptionDocEmitter.cpp:272
+        Alias->getValueAsListOfStrings("Prefixes").front(), Alias,
+        std::vector<std::string>(AliasArgs.begin(), AliasArgs.end()), OS);
     OS << ")";
----------------
Had to make a copy into vector std::string because emitOptionWithArgs has another caller that passes a std::string vector.


https://reviews.llvm.org/D33711





More information about the llvm-commits mailing list