[PATCH] D31188: [AntiDepBreaker] Use liveins as well in StartBlock

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 15:04:58 PDT 2017


timshen added a comment.

In https://reviews.llvm.org/D31188#766336, @MatzeB wrote:

> In https://reviews.llvm.org/D31188#766326, @timshen wrote:
>
> > In https://reviews.llvm.org/D31188#765178, @MatzeB wrote:
> >
> > > Ok, now that r303938 / https://reviews.llvm.org/D32464 has landed could you please double check and then revert this?
> >
> >
> > https://reviews.llvm.org/D32464 doesn't seem to fix this test case - I ran pass post-RA-sched on this test case, and got bb.2.if.then not having X29 as live-in. Can you take a look?
>
>
> The original testcase? The mir test in the repository already has the invalid livein lists from the earlier branch folding.


Yes you are right. Posted https://reviews.llvm.org/D33697 to revert.


https://reviews.llvm.org/D31188





More information about the llvm-commits mailing list